Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server::Builder stream/connection window size methods work by reference #1814

Closed
sfackler opened this issue May 12, 2019 · 2 comments
Closed

server::Builder stream/connection window size methods work by reference #1814

sfackler opened this issue May 12, 2019 · 2 comments
Labels
A-server Area: server. B-breaking-change Blocked: this is an "API breaking change". E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Milestone
0.13

Comments

@sfackler
Copy link
Contributor

All of the other setters on the builder type operate by-value, but http2_initial_connection_window_size and http2_initial_stream_window size work by-reference.
@seanmonstar
Copy link
Member

Ah man, that's an unfortunate mistake. I'll assign this breaking change to be done in 0.13.

@seanmonstar seanmonstar added this to the 0.13 milestone May 14, 2019
@seanmonstar seanmonstar added A-server Area: server. B-breaking-change Blocked: this is an "API breaking change". E-easy Effort: easy. A task that would be a great starting point for a new contributor. labels May 14, 2019
@seanmonstar
Copy link
Member

As an interim, we could add new methods that are by-value, with an underscore prefix... 🤷‍♂️

seanmonstar added a commit that referenced this issue May 16, 2019
@seanmonstar
feat(server): add initial window builder methods that take self by-val
89a0e36 
The current `Builder` methods `http2_initial_stream_window_size` and
`http2_initial_connection_window_size` take `&mut self`, while every
other builder method takes `self`. That breaks up the chaining of
options.

This patch adds two methods that configure the same option, but take
`self` instead, and have an underscore suffix (so,
`http2_initial_stream_window_size_`).

cc #1814
@seanmonstar seanmonstar mentioned this issue May 16, 2019
Merged
seanmonstar added a commit that referenced this issue May 16, 2019
@seanmonstar
feat(server): add initial window builder methods that take self by-val (
8b45af7 
#1817)

The current `Builder` methods `http2_initial_stream_window_size` and
`http2_initial_connection_window_size` take `&mut self`, while every
other builder method takes `self`. That breaks up the chaining of
options.

This patch adds two methods that configure the same option, but take
`self` instead, and have an underscore suffix (so,
`http2_initial_stream_window_size_`).

cc #1814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-server Area: server. B-breaking-change Blocked: this is an "API breaking change". E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
None yet
Milestone
0.13
Development

No branches or pull requests
2 participants
@seanmonstar @sfackler