Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable tests for 0.13 #1848

Closed
5 tasks done
seanmonstar opened this issue Jul 9, 2019 · 5 comments
Closed
5 tasks done

Re-enable tests for 0.13 #1848

seanmonstar opened this issue Jul 9, 2019 · 5 comments
Labels
A-tests Area: tests. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Milestone

Comments

@seanmonstar
Copy link
Member

seanmonstar commented Jul 9, 2019

As part of merging #1836 (related to #1805), running the tests in CI was disabled. They should be re-enabled as we go along.

  • The --lib tests
  • benches directory
  • tests/client
  • tests/server
  • tests/integration
@seanmonstar seanmonstar added E-easy Effort: easy. A task that would be a great starting point for a new contributor. A-tests Area: tests. labels Jul 9, 2019
@seanmonstar seanmonstar added this to the 0.13 milestone Jul 9, 2019
@jakubadamw
Copy link
Contributor

The tests/client bit is done in #1881.

@apiraino
Copy link

apiraino commented Aug 27, 2019

@seanmonstar or anyone else, could you pls also add an example on how to use the Service and MakeService trait?

(I'm on Hyper 0.12 and having a hard time to figure that out. I'd be happy if for 0.13 that to be more discoverable).

thanks 👍

By the way: examples are of the essence for a library and I thank you so much for having written them! More of them, pls :-)

EDIT: https://stackoverflow.com/questions/57371130/hyper-0-12-x-implementing-service-for-a-struct

@Mathspy
Copy link

Mathspy commented Sep 7, 2019

I think this is finally closed by #1882

@weihanglo
Copy link
Contributor

@Mathspy
Not really. Some tests under src/client are still disabled. Most related to a new mock service implementations.

@seanmonstar
Copy link
Member Author

I'm going to close this, as almost all tests have been re-enabled. I've removed the warning about the missing tests in client/tests.rs, as re-writing them is rather tricky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tests Area: tests. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants