-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to std::future #1836
Update to std::future #1836
Conversation
@seanmonstar: I believe that working with Looking at the unsafe code you've added, all of it seems to be to support pin projections for custom This means that you should be able to add an unconditional |
Most things have been updated. Still lacking http2 (hitting those paths will find an Master is now tracking 0.13, so I'm going to disable tests and then merge this to master, and file issues to re-enable tests and examples. Hopefully those are smaller chunks that can be parallelized better. |
BREAKING CHANGE: All usage of async traits (`Future`, `Stream`, `AsyncRead`, `AsyncWrite`, etc) are updated to newer versions.
@seanmonstar JFYI current master cannot be built without |
@DoumanAsh woops, thanks for letting me know. Master should now be working (though the client doesn't quite have a way to set a custom executor...). |
looks like setting a custom executor requires passing in something that implements tokio_executor::Executor. Should this be changed to futures::task::Spawn? |
I think not yet. In fact, both are kinda unstable. I might suggest we just take a closure instead of some 3rd party trait. We can discuss that in its own issue. |
This is a WIP branch of the update from
futures
v0.1 tostd::future::Future
. I'm posting it so the outside can track progress, and allow others to try to contribute. See #1805.Steps
futures
v0.1 from dependenciestokio
master that hasstd::future
supportexamples/hello.rs
runs and sends responsesdispatch
channelConnect
traitPool
examples/client.rs
runs and prints the bodyhyper::Body
h2
supportunsafe
usage ofPin
😭