Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename unstable-stream feature to just stream #2034

Closed
seanmonstar opened this issue Dec 4, 2019 · 3 comments · Fixed by #2042
Closed

Rename unstable-stream feature to just stream #2034

seanmonstar opened this issue Dec 4, 2019 · 3 comments · Fixed by #2042
Labels
E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Milestone

Comments

@seanmonstar
Copy link
Member

While hyper is pre-1.0, it's not really fair to say other pre-1.0 dependencies are unstable.

Should stream be enabled by default?

@seanmonstar seanmonstar added the E-easy Effort: easy. A task that would be a great starting point for a new contributor. label Dec 4, 2019
@seanmonstar seanmonstar added this to the 0.13 milestone Dec 4, 2019
@hwchen
Copy link

hwchen commented Dec 4, 2019

To me, Stream seemed like a core trait, just like Future, so I was surprised when I had to switch it on in hyper.

I know that the reality around what’s core at the moment is a bit more complicated at the moment, but the above is just my initial reaction.

I would vote yes for stream as default, but perhaps there’s downsides I didn’t think of.

@davidbarsky
Copy link
Contributor

I think it should be. Worst comes to worst, Hyper can issue a smaller 0.14 release that walks back on the on-by-default stream feature.

@davidbarsky
Copy link
Contributor

I forgot to note this, but: I think it's reasonable to say that a hypothetical 0.14 release will come out in a half a year to a year's time. I don't believe Stream will be in the standard library six months from now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants