Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http1 options are exposed through client::Builder but not lower-level client::conn::Builder interface #2461

Closed
acfoltzer opened this issue Mar 11, 2021 · 1 comment · Fixed by #2611
Closed

http1 options are exposed through client::Builder but not lower-level client::conn::Builder interface #2461

acfoltzer opened this issue Mar 11, 2021 · 1 comment · Fixed by #2611
Labels
A-client Area: client. E-easy Effort: easy. A task that would be a great starting point for a new contributor.

Comments

@acfoltzer
Copy link
Member

http1_read_buf_exact_size, http1_max_buf_size, and http1_title_case_headers are all configuration methods on hyper::client::Builder, but not hyper::client::conn::Builder. I notice that the methods are present on the latter type but are pub(super) rather than pub.

Currently, I believe users of the conn interface are stuck with the default values of these settings. Are there any reasons not to make these pub with similar docstrings to the higher-level API? I'd be happy to provide a PR if not.
@seanmonstar
Copy link
Member

I believe it is simply an oversight. I'd say more of the builder options also make sense on the conn types (besides pooling, listener config, the obvious).

@seanmonstar seanmonstar added A-client Area: client. E-easy Effort: easy. A task that would be a great starting point for a new contributor. labels Mar 11, 2021
aturon added a commit to aturon/hyper that referenced this issue Aug 3, 2021
@aturon
Expose http09 and http1 options on low-level
e797fe3 
client connection builders.

These options are currently available on the high-level builder only.

Along the way, rename the setters to follow the public API conventions
and add docs.

Closes hyperium#2461
@aturon aturon mentioned this issue Aug 3, 2021
Merged
seanmonstar pushed a commit that referenced this issue Aug 4, 2021
@aturon
feat(client): expose http09 and http1 options on `client::conn::Build…
73bff4e 
…er` (#2611)

These options are currently available on the high-level builder only.

Along the way, rename the setters to follow the public API conventions
and add docs.

Closes #2461
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-client Area: client. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose http09 and http1 options on low-level client connection builders. aturon/hyper
2 participants
@seanmonstar @acfoltzer