-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple Content-Length values #2470
Comments
I coulda sworn hyper supported this, and so dug a little. hyper does correctly support if the multiple values are on multiple lines, but not if comma-separated. So, this works:
But not |
The relevant code is this function: Line 40 in eb0e718
|
Ok, i'll provide a PR |
@seanmonstar it's not particularly important now, but the original ticket did say "to be more precise, hyper does not handle the multiple values into only one header entry" - which I read as meaning that multiple header entries would work as you independently found. No harm in you having dug to confirm it, obviously, but a principle of "credit where due" meant it seemed worth pointing out that @ghostd had spotted that bit already too :) |
Hi,
I try to work on some failing tests of servo. To summarize the issue : the
fetch
specification has been recently updated to handle multiple values for theContent-Length
header. I found Hyper client does not handle the header as expected by the specification. To be more precise, hyper does not handle the multiple values into only one header entry :Content-Length: 42,42
. I don't know if we want to update hyper to follow this specification or not.I reproduced the error with the example client and the following node http server code:
The text was updated successfully, but these errors were encountered: