Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal serialization of debug_data to HTTP/2 GOAWAY frames #3200

Closed
seanmonstar opened this issue Apr 13, 2023 · 1 comment · Fixed by hyperium/h2#673
Closed

Add internal serialization of debug_data to HTTP/2 GOAWAY frames #3200

seanmonstar opened this issue Apr 13, 2023 · 1 comment · Fixed by hyperium/h2#673
Labels
A-http2 Area: HTTP/2 specific. C-feature Category: feature. This is adding a new feature. E-easy Effort: easy. A task that would be a great starting point for a new contributor.

Comments

@seanmonstar
Copy link
Member

It would be useful to be able to send the additional debug_data in HTTP/2 GOAWAY frames. The frame currently has a field to hold it, and uses that when decoding, but if we try to send a frame with extra data, it gets ignored. Here's some steps to get this done:

  • Set the payload length and serialize the debug_data in GoAway::encode
  • Add a fn data(self, b: Into<Bytes>) method to the frames test support.
  • Add a unit test to h2-tests showing debug data was serialized.
@seanmonstar seanmonstar added E-easy Effort: easy. A task that would be a great starting point for a new contributor. C-feature Category: feature. This is adding a new feature. A-http2 Area: HTTP/2 specific. labels Apr 13, 2023
@Herbstein
Copy link

I picked this up in the linked PR. Though I do expect a bit of guidance is necessary to bring it up to snuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-http2 Area: HTTP/2 specific. C-feature Category: feature. This is adding a new feature. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants