Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation link in hyper::client::conn for "Higher-level Client API" should probably go to hyper-util now #3453

Open
taladar opened this issue Dec 1, 2023 · 1 comment
Labels
C-bug Category: bug. Something is wrong. This is bad!

Comments

@taladar
Copy link

taladar commented Dec 1, 2023

Version
1.0.1

https://docs.rs/hyper/1.0.1/hyper/client/conn/index.html

The link just goes to the module hyper::client above which only contains conn now. Presumably it refers to the code now moved to hyper-util.

@taladar taladar added the C-bug Category: bug. Something is wrong. This is bad! label Dec 1, 2023
GlenDC pushed a commit to GlenDC/hyper that referenced this issue Dec 22, 2023
@ketzu
Copy link

ketzu commented Jan 2, 2024

After looking out what happend to hyper::Client after stumbling over it in some examples (for sharing a pooled connection in axum), I ended up here. (New to rust, so sorry if I break some conventions or seem rude😅 )

My adventure through this issue, thanks for that :) But the resulting question kind of plays into this:

  • hyper-util, as a new target for the link, already labels the Client as legacy, should anyone be encouraged to use legacy for new code?
  • reqwest (the link provided in the commit 5236ac5) here, depends on hyper 0.14, using hyper::Client internally, as far as I can tell, implying the recommendation of hyper to get a pooled connection is to use an older version of hyper.

As I am new to this, I might misunderstand some things around this :) I'll just leave it as food for thought though (and because I secretly hope I'll end up with a recommendation for a higher level client api)

GlenDC pushed a commit to GlenDC/hyper that referenced this issue Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug. Something is wrong. This is bad!
Projects
None yet
Development

No branches or pull requests

2 participants