Switch to new std::io #347

John-Nagle · 2015-02-28T06:52:09Z

Installed Rust nightly build, after not using Rust for 3 weeks. Hyper won't compile any more.
The I/O libraries changed. Again. Not your fault. Sigh.

Compiling hyper v0.2.1
/home/john/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.2.1/src/net.rs:215:25: 215:29 error: mismatched types:
 expected `&std::path::Path`,
    found `&std::old_path::posix::Path`
(expected struct `std::path::Path`,
    found struct `std::old_path::posix::Path`) [E0308]
/home/john/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.2.1/src/net.rs:215                         cert, X509FileType::PEM).map(lift_ssl_error));
                                                                                                              ^~~~
/home/john/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.2.1/src/net.rs:19:1: 24:2 note: in expansion of try_some!
/home/john/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.2.1/src/net.rs:214:17: 215:71 note: expansion site
/home/john/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.2.1/src/net.rs:217:25: 217:28 error: mismatched types:
 expected `&std::path::Path`,
    found `&std::old_path::posix::Path`
(expected struct `std::path::Path`,
    found struct `std::old_path::posix::Path`) [E0308]
/home/john/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.2.1/src/net.rs:217                         key, X509FileType::PEM).map(lift_ssl_error));
                                                                                                              ^~~
/home/john/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.2.1/src/net.rs:19:1: 24:2 note: in expansion of try_some!
/home/john/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.2.1/src/net.rs:216:17: 217:70 note: expansion site
/home/john/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.2.1/src/net.rs:243:23: 243:57 error: the trait `std::io::Read` is not implemented for the type `std::old_io::net::tcp::TcpStream` [E0277]
/home/john/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.2.1/src/net.rs:243                 match SslStream::<TcpStream>::new_server(&**ssl_context, stream) {
                                                                                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/john/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.2.1/src/net.rs:243:23: 243:57 error: the trait `std::io::Write` is not implemented for the type `std::old_io::net::tcp::TcpStream` [E0277]
/home/john/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.2.1/src/net.rs:243                 match SslStream::<TcpStream>::new_server(&**ssl_context, stream) {
                                                                                                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/john/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.2.1/src/net.rs:249:42: 249:48 error: attempted access of field `desc` on type `&std::io::error::Error`, but no field with that name was found
/home/john/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.2.1/src/net.rs:249                             detail: Some(e.desc.to_string())
                                                                                                                               ^~~~~~
/home/john/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.2.1/src/net.rs:289:55: 289:64 error: type `&mut openssl::ssl::SslStream<std::old_io::net::tcp::TcpStream>` does not implement any method in scope named `read`
/home/john/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.2.1/src/net.rs:289             HttpStream::Https(ref mut inner) => inner.read(buf)
                                                                                                                                            ^~~~~~~~~
/home/john/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.2.1/src/net.rs:299:55: 299:69 error: type `&mut openssl::ssl::SslStream<std::old_io::net::tcp::TcpStream>` does not implement any method in scope named `write_all`
/home/john/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.2.1/src/net.rs:299             HttpStream::Https(ref mut inner) => inner.write_all(msg)
                                                                                                                                            ^~~~~~~~~~~~~~
/home/john/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.2.1/src/net.rs:306:55: 306:62 error: type `&mut openssl::ssl::SslStream<std::old_io::net::tcp::TcpStream>` does not implement any method in scope named `flush`
/home/john/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.2.1/src/net.rs:306             HttpStream::Https(ref mut inner) => inner.flush(),
                                                                                                                                            ^~~~~~~
/home/john/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.2.1/src/net.rs:315:55: 315:64 error: type `&mut openssl::ssl::SslStream<std::old_io::net::tcp::TcpStream>` does not implement any method in scope named `get_mut`
/home/john/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.2.1/src/net.rs:315             HttpStream::Https(ref mut inner) => inner.get_mut().peer_name()
                                                                                                                                            ^~~~~~~~~
/home/john/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.2.1/src/net.rs:346:35: 346:49 error: the trait `std::io::Read` is not implemented for the type `std::old_io::net::tcp::TcpStream` [E0277]
/home/john/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.2.1/src/net.rs:346                 let stream = try!(SslStream::new(&context, stream).map_err(lift_ssl_error));
                                                                                                                        ^~~~~~~~~~~~~~
<std macros>:1:1: 6:57 note: in expansion of try!
/home/john/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.2.1/src/net.rs:346:30: 346:93 note: expansion site
/home/john/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.2.1/src/net.rs:346:35: 346:49 error: the trait `std::io::Write` is not implemented for the type `std::old_io::net::tcp::TcpStream` [E0277]
/home/john/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.2.1/src/net.rs:346                 let stream = try!(SslStream::new(&context, stream).map_err(lift_ssl_error));
                                                                                                                        ^~~~~~~~~~~~~~
<std macros>:1:1: 6:57 note: in expansion of try!
/home/john/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.2.1/src/net.rs:346:30: 346:93 note: expansion site
/home/john/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.2.1/src/net.rs:363:29: 363:32 error: mismatched types:
 expected `std::old_io::IoError`,
    found `std::io::error::Error`
(expected struct `std::old_io::IoError`,
    found struct `std::io::error::Error`) [E0308]
/home/john/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.2.1/src/net.rs:363         StreamError(err) => err,
                                                                                                                  ^~~
error: aborting due to 12 previous errors
Could not compile `hyper`.

The text was updated successfully, but these errors were encountered:

ghost · 2015-02-28T07:00:08Z

What is your rustc version? are you updated?

John-Nagle · 2015-02-28T07:09:56Z

rustc 1.0.0-nightly (4db0b3246 2015-02-25) (built 2015-02-26)
That's two hours old; it may be obsolete by now.

John-Nagle · 2015-02-28T07:23:26Z

It looks like old_io just went away. Although I'm not entirely sure. Here's the reddit discussion:

http://www.reddit.com/r/rust/comments/2wrc3c/read_from_stdin_in_alpha_2_without_using_old_io/

golddranks · 2015-02-28T09:27:05Z

No, it's the upstream changes that broke the thing. OpenSSL and Cookie now use new paths. (Sorry, I kinda participated in making that happen, but then again... THEY broke because their upstream dependencies moved to use the new paths. So something's gotta be done.)

golddranks · 2015-02-28T09:32:39Z

Btw. I'm currently tinkering with Hyper, trying to fix things. No promises (I'm a rust noob), but I'll send a PR right away if I manage to get it to build.

reem · 2015-02-28T09:34:41Z

I should've said something earlier, but I actually started working on a fix a while ago (hours ago). The io changes touch a lot of code, so the fix is very large. I'm haven't finished the entire thing yet, and am going to bed, but will finish up tomorrow.

seanmonstar · 2015-02-28T15:58:16Z

@reem i'm just about done with the patch. I found out from sfackler that the change was coming, and started working on it right away.

John-Nagle · 2015-02-28T18:42:57Z

Thanks for all the quick effort.

"My dear, here we must run as fast as we can, just to stay in place." - Alice in Wonderland

reem · 2015-02-28T22:41:33Z

@seanmonstar I'll defer to your patch then, instead of finishing mine.

reem · 2015-03-01T02:21:26Z

@seanmonstar any progress? I can work on a patch if you're busy.

seanmonstar · 2015-03-01T02:26:41Z

@reem yes progress. Everything compiles, just fixing up a couple broken tests. Should have PR shortly.

All instances of `old_io` and `old_path` were switched to use the new shiny `std::io`, `std::net`, and `std::path` modules. This means that `Request` and `Response` implement `Read` and `Write` now. Because of the changes to `TcpListener`, this also takes the opportunity to correct the method usage of `Server`. As with other languages/frameworks, the server is first created with a handler, and then a host/port is passed to a `listen` method. This reverses what `Server` used to do. Closes #347 BREAKING CHANGE: Check the docs. Everything was touched.

softprops · 2015-03-02T01:12:58Z

just ran into the same issue :/

miketang84 · 2015-03-02T04:00:47Z

the same :(

pyfisch · 2015-03-02T05:51:29Z

@softprops @daogangtang You can use PR #354 for now.

softprops · 2015-03-02T13:24:43Z

Yep, I'm depending on git revs for now

[dependencies.hyper]
git = "https://github.com/hyperium/hyper.git"
rev = "2ce4385c163e1a9a393c89743cf04e047b776e83"

John-Nagle · 2015-03-03T20:44:15Z

Is "Read" live in the rev mentioned above? I'm getting

src/rssread.rs:258:28: 258:34 error: type `hyper::client::response::Response` does not implement any method in scope named `Read`
src/rssread.rs:258     let string = match res.Read() {

Should I wait a few more days for things to settle down?

All instances of `old_io` and `old_path` were switched to use the new shiny `std::io`, `std::net`, and `std::path` modules. This means that `Request` and `Response` implement `Read` and `Write` now. Because of the changes to `TcpListener`, this also takes the opportunity to correct the method usage of `Server`. As with other languages/frameworks, the server is first created with a handler, and then a host/port is passed to a `listen` method. This reverses what `Server` used to do. Closes #347 BREAKING CHANGE: Check the docs. Everything was touched.

seanmonstar · 2015-03-03T23:15:21Z

@John-Nagle Read is the new trait replacing Reader. You need to import std::io::Read, as it isn't part of the prelude. Then, you can use methods read, read_to_end, and read_to_string.

John-Nagle · 2015-03-04T06:55:15Z

OK, got that. My RSS reader is working again with the latest Hyper, thanks to all of you.

seanmonstar changed the title ~~Rust changes broke it again/~~ Switch to new std::io Mar 1, 2015

seanmonstar mentioned this issue Mar 1, 2015

feat(hyper): switch to std::io, std::net, and std::path. #354

Merged

seanmonstar closed this as completed in #354 Mar 3, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch to new std::io #347

Switch to new std::io #347

John-Nagle commented Feb 28, 2015

ghost commented Feb 28, 2015

John-Nagle commented Feb 28, 2015

John-Nagle commented Feb 28, 2015

golddranks commented Feb 28, 2015

golddranks commented Feb 28, 2015

reem commented Feb 28, 2015

seanmonstar commented Feb 28, 2015

John-Nagle commented Feb 28, 2015

reem commented Feb 28, 2015

reem commented Mar 1, 2015

seanmonstar commented Mar 1, 2015

softprops commented Mar 2, 2015

miketang84 commented Mar 2, 2015

pyfisch commented Mar 2, 2015

softprops commented Mar 2, 2015

John-Nagle commented Mar 3, 2015

seanmonstar commented Mar 3, 2015

John-Nagle commented Mar 4, 2015

Switch to new std::io #347

Switch to new std::io #347

Comments

John-Nagle commented Feb 28, 2015

ghost commented Feb 28, 2015

John-Nagle commented Feb 28, 2015

John-Nagle commented Feb 28, 2015

golddranks commented Feb 28, 2015

golddranks commented Feb 28, 2015

reem commented Feb 28, 2015

seanmonstar commented Feb 28, 2015

John-Nagle commented Feb 28, 2015

reem commented Feb 28, 2015

reem commented Mar 1, 2015

seanmonstar commented Mar 1, 2015

softprops commented Mar 2, 2015

miketang84 commented Mar 2, 2015

pyfisch commented Mar 2, 2015

softprops commented Mar 2, 2015

John-Nagle commented Mar 3, 2015

seanmonstar commented Mar 3, 2015

John-Nagle commented Mar 4, 2015