Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(client): Remove parked senders when a checkout is dropped to prevent memory leaks #1324

Closed
wants to merge 2 commits into from

Conversation

klausi
Copy link
Contributor

@klausi klausi commented Sep 17, 2017

Attempt to fix #1315 .

Note that I'm not sure what I'm doing here is right because I have not groked yet what the purpose of those parked senders is.

@seanmonstar
Copy link
Member

Thanks for getting it this far, it helped me understand where the leak is. Completely removing the parked list could hurt any other pending requests, making the client use idle connections less often. I've opened #1325 that will cleanup when a Checkout is dropped, but only if the Sender is dead.

@klausi
Copy link
Contributor Author

klausi commented Sep 18, 2017

Very good, glad I could help at least some way :-)

@klausi klausi closed this Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak when using client.clone() for server (proxy)
2 participants