Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): Allow keep alive to be turned off for a connection #1390

Merged
merged 1 commit into from
Dec 4, 2017

Conversation

sfackler
Copy link
Contributor

Closes #1365

@sfackler
Copy link
Contributor Author

This currently only allows you to disable keepalive rather than providing a toggle since the only use case I'm aware of involves turning it off and it seems a bit less risky to go in that direction only.

@seanmonstar
Copy link
Member

Hm, I wonder if this will work while the connection is currently "parked". I guess if you have the Connection future, and call this function, then a later call to poll will notice that the state is disabled, and end, right?

@sfackler
Copy link
Contributor Author

sfackler commented Dec 1, 2017

Nice catch - fixed and added a test for that case as well.

@seanmonstar seanmonstar merged commit eb9590e into hyperium:master Dec 4, 2017
@sfackler sfackler deleted the connection-shutdown branch December 5, 2017 17:19
@karuna karuna mentioned this pull request Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants