feat(client): add HttpConnector::set_global_destination_only #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow restricting destinations to addresses that appear to be publicly routable. This can be a useful security measure when connecting to user defined URLs.
|
Sorry for taking so long to get to this, it slipped out of my notifications. I'd probably be more in favor of #1517, which allows for plugging in some custom DNS resolving logic, instead of adding more and more knobs to the |
|
Makes sense. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow restricting destinations to addresses that appear to be
publicly routable. This can be a useful security measure when
connecting to user defined URLs.
Is this something you would consider including? Or if not, is there a more elegant way to build this outside of hyper than copying the entire HttpConnector implementation?