Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic azure pipelines configuration #1844

Closed
wants to merge 1 commit into from

Conversation

Perseus101
Copy link

@Perseus101 Perseus101 commented Jul 8, 2019

References #1673

I've added a fairly basic azure pipelines configuration that tests stable on windows, and mac, and tests stable, beta, and nightly on linux.

I ran a manual build in a test azure project and there were 2 failures:

  • linux-nightly: Looks like a trivial fix. Just some deprecation warnings.
  • windows: 2 tests hung. I'm not sure what the cause was exactly, I'm going to do some more investigating. The failing test were:
    • http2_body_user_error_sends_reset_reason
    • http2_service_error_sends_reset_reason

@Perseus101
Copy link
Author

Forgive my ignorance, it's my first time contributing here. I wasn't really sure what "scope" to throw this under, so I picked "headers" because it was first on the list in the contribution guidelines. Let me know what I should change it to.

@LucioFranco
Copy link
Member

Hi! This looks like a good start! Im just gonna drop a link to https://github.com/tokio-rs/tokio as we have been using azure there and are pretty happy so maybe there are things you can pull from there as well!

@ahmedcharles
Copy link
Contributor

chore(ci) seems better than chore(headers) given that the list in the contribution guidelines is just of examples.

I suspect that rebasing will fix the travis nightly failure.

Add a basic azure configuration that runs tests and benchmarks
on linux, mac, and windows.

Closes hyperium#1673
@Perseus101
Copy link
Author

Perseus101 commented Sep 9, 2019

@ahmedcharles Thanks for the recommendation, rebasing fixed the test failures.

I've added some small azure pipelines templates, following the example of the tokio repository (Thanks @LucioFranco!). Using those templates, the pipelines can be configured for different platforms, rust versions, and features quite easily from the azure-pipelines.yml file. Currently, I've added entries to the test matrix mirroring what is present in the .travis.yml file. I've created a PR here on my fork to show how the results appear.

@Perseus101
Copy link
Author

I'm not sure if the maintainers want to wait until after 0.13 to merge this, but I think this is ready to go.

@seanmonstar
Copy link
Member

As an update, the hyper repo just got accepted into GitHub Actions, which may make managing our CI even easier...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants