feat(client): change GaiResolver to use a global blocking threadpool
#1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does the resolver interface need to exist at all anymore once |
|
Maybe |
seanmonstar
force-pushed
the
gai-blocking
branch
from
8f7ec7a
to
0d24e94
Compare
BREAKING CHANGE: Calls to `GaiResolver::new` and `HttpConnector::new` no longer should pass an integer argument for the number of threads.
seanmonstar
force-pushed
the
gai-blocking
branch
from
0d24e94
to
d521ee2
Compare
seanmonstar
pushed a commit
that referenced
this pull request
Sep 6, 2019
* test(http): use async/.await Signed-off-by: Weihang Lo <me@weihanglo.tw> * test(pool): use async/.await * test(pool): pass &mut Future into PollOnce * test(client): tests/benches using async/.await * test(client): change due to PR #1917 * test(client): change Delay to delay fucntion Ref: tokio-rs/tokio#1440 * test(client): remove warning triggers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Calls to
GaiResolver::newandHttpConnector::newnolonger should pass an integer argument for the number of threads.