feat(client): expose hyper::client::connect::Connect trait alias
#2073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
force-pushed
the
expose-connect-alias
branch
from
4124c8d to
11d4250
Compare
This is *just* a "trait alias". It is automatically implemented for all `Service<Uri>`s that have the required bounds. It's purpose being public is to ease setting trait bounds outside of hyper. Therefore, it doesn't have any exposed associated types, to prevent otherwise relying on any super-traits that hyper requires.
seanmonstar
force-pushed
the
expose-connect-alias
branch
from
11d4250 to
ba2cb60
Compare
|
I wonder if it makes sense to work off of |
I don't think that will do what this does: allow someone to add the bounds without depending on the extra bounds. |
|
Also my worry about things accross the ecosystem isn't an issue if we lift the other trait alias. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a "trait alias". It is automatically implemented for all
Service<Uri>s that have the required bounds. It's purpose being publicis to ease setting trait bounds outside of hyper. Therefore, it doesn't
have any exposed associated types, to prevent otherwise relying on any
super-traits that hyper requires.