fix(server): skip automatic Content-Length headers when not allowed #2216
Conversation
|
Note that some old tests fail at this moment. I'll fix those after getting feedback whether this is the right way to fix this issue. |
|
It's probably somewhere in that code, for sure! I'd suggest starting by modifying this test case to check there is no |
psmit
force-pushed
the
content_length_fixes
branch
2 times, most recently
from
f7ceff8
to
4570076
Compare
|
Thanks for the hint. I adjusted 2 test cases and now the PR is ready for review. |
psmit
force-pushed
the
content_length_fixes
branch
from
4570076
to
bb8e341
Compare
|
@seanmonstar I have modified the code accordingly. Could you please review it again? |
|
@psmit just curious: are you still interested in driving this? We're affected by this issue as well and would love to see the fix go in. Thanks! :) |
Backported from hyperium#2216.
Backported from hyperium#2216.
|
Hi @krallin, my apologies, I had not realized that this PR wasn't merged yet and your reminder got lost in my mail box. I'll be working now to get this PR finished. |
|
Is anything blocking this PR? |
Backported from hyperium#2216.
Not to my knowledge, we just have to wait for the review to be done. |
|
Sorry, I got distracted. This looks good to me, let's go! Thanks for sticking with it <3 |
|
@seanmonstar any plans to cut a new release? We'd love to stop having to use a fork of Hyper just to get this :) |
|
I was hoping to get #2473 merged today or tomorrow, and then do a release. If it gets delayed, I'll release anyways. So either way, there should be a 0.14.5 today or tomorrow. |
|
awesome, thank you! :)
…On Thu, 25 Mar 2021 at 20:29, Sean McArthur ***@***.***> wrote:
I was hoping to get #2473 <#2473>
merged today or tomorrow, and then do a release. If it gets delayed, I'll
release anyways. So either way, there should be a 0.14.5 today or tomorrow.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2216 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANIHVQIQFKFTGRG6M2PF5TTFOMKXANCNFSM4NRQJ4FA>
.
|
Closes #2215