Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pin-project-lite #2393

Merged
merged 2 commits into from
Jan 28, 2021
Merged

Conversation

jplatte
Copy link
Contributor

@jplatte jplatte commented Jan 11, 2021

Will fix #2388.

Blocked on taiki-e/pin-project-lite#3. (workaround)
Blocked on taiki-e/pin-project-lite#25. (see comment below)

@paolobarbolini
Copy link
Contributor

After looking back at the issue I was able to remove the use of PinnedDrop in #2405, so we won't have to wait for PinnedDrop to land in pin-project-lite

@jplatte jplatte marked this pull request as ready for review January 26, 2021 13:48
Cargo.toml Outdated Show resolved Hide resolved
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thanks so much!

(Weird that Github doesn't notify me that your marked it ready to review 🤷 )

@seanmonstar seanmonstar merged commit 43412a9 into hyperium:master Jan 28, 2021
@jplatte jplatte deleted the pin-project-lite branch January 28, 2021 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from pin-project to pin-project-lite
3 participants