Allow to config h2 max concurrent reset streams. #2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boxdot
force-pushed
the
config-max-reset-streams
branch
2 times, most recently
from
171aea1
to
d231963
Compare
pickfire
reviewed
May 4, 2021
boxdot
force-pushed
the
config-max-reset-streams
branch
from
d231963
to
7ca0433
Compare
pickfire
reviewed
May 5, 2021
boxdot
force-pushed
the
config-max-reset-streams
branch
from
7ca0433
to
75b3d17
Compare
Setting streams to 0 makes h2 work on wasm platforms without a `Instant::now` implementation. The default value if derived from the default value in the h2 crate.
boxdot
force-pushed
the
config-max-reset-streams
branch
from
75b3d17
to
aba1761
Compare
seanmonstar
approved these changes
May 12, 2021
|
I've got #2548 going to fix the weird failure on nightly. |
BenxiangGe
pushed a commit
to BenxiangGe/hyper
that referenced
this pull request
Jul 26, 2021
…erium#2535) Setting streams to 0 makes h2 work on wasm platforms without a `Instant::now` implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting streams to 0 makes h2 work on wasm platforms without
Instant::nowimplementation.Related to:
Instant::nowwhen zero reset streams are configured. h2#537