feat(server): remove addrstream struct #2869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks for starting! I need to get the branch ready to start the new version, within the next day or two, and then I'll just start |
|
Cool! I'd love to work on some of the other easy issues from your stream tommorow. I see the CI failed because AddrStream is imported in the |
remove addrstream type, it provides no benefit over tokio::net::tcpstream closes issue hyperium#2850
|
I updated the |
seanmonstar
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
AddrStreamtype, it provides no benefit overtokio::net::TcpStream.Closes issue #2850
This is my first contribution to this project, so I may have missed something. I am happy to take any feedback. Thanks!
Notes
AddrIncoming.poll_next_method are correct, or if that method is actually used anywhere.AddrStreamis used in documentation related tomake_service, but as I understand it,make_servicewill be removed anyway in a different PR. Ref issue Remove the MakeService stuff #2854