Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Split server conn types #2996

Closed

Conversation

Michael-J-Ward
Copy link
Contributor

@Michael-J-Ward Michael-J-Ward commented Sep 25, 2022

Closes #2851

If someone takes a look and provides some guidance, I'll execute the next steps.

TODO:

  • create separate http1 type
  • create separate http2 type
  • configuring / constructing?
  • excise old server::conn::Connection

@seanmonstar
Copy link
Member

Thanks for getting started with this! You said you think next steps are configuration? The Http type could likely be split into a Builder in each module, only including the relevant version methods. Similar to how it is in client::conn.

@seanmonstar
Copy link
Member

Thank you for the big start! I've finished up the split in #3011.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split the server Connection type into version-specific submodules
2 participants