fix(h2): add http2_max_header_list_size to hyper::server::Builder #3006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @seanmonstar, as discussion in #2828 , add http2_max_header_list_size to hyper::server::Builder to expose the API in 0.14.x version. Please review, thanks. |
fix incomplete changes introduced from hyperium#2828
seanmonstar
approved these changes
Dec 2, 2022
|
@seanmonstar Hi Sean, I don’t understand how this change failed Miri test. How may I pass it? Thanks. |
|
@seanmonstar Hi Sean, sorry to bother you again. How may I get through the Miri test for this PR? |
|
I restarted the Miri check, and it worked. It seems there was an issue in Miri for a little while that they reverted. |
bors bot
referenced
this pull request
in OpenPoolProject/stratum
Feb 2, 2023
454: fix(deps): update rust crate hyper to 0.14.24 r=renovate[bot] a=renovate[bot] [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [hyper](https://hyper.rs) ([source](https://togithub.com/hyperium/hyper)) | dependencies | patch | `0.14.23` -> `0.14.24` | --- ### Release Notes <details> <summary>hyperium/hyper</summary> ### [`v0.14.24`](https://togithub.com/hyperium/hyper/releases/tag/v0.14.24) [Compare Source](https://togithub.com/hyperium/hyper/compare/v0.14.23...v0.14.24) #### Bug Fixes - **body:** set an internal max to reserve in `to_bytes` ([4d89adce](https://togithub.com/hyperium/hyper/commit/4d89adce6122af1650165337d9d814314e7ee409)) - **server:** prevent sending 100-continue if user drops request body ([#​3138](https://togithub.com/hyperium/hyper/issues/3138)) ([92443d7e](https://togithub.com/hyperium/hyper/commit/92443d7ef57ed474f0add7dd1f114c81a3faa8fe)) #### Features - **http2:** add `http2_max_header_list_size` to `hyper::server::Builder` ([#​3006](https://togithub.com/hyperium/hyper/issues/3006)) ([031425f0](https://togithub.com/hyperium/hyper/commit/031425f087219f02a87eea3d01b14e75e35a5209)) #### New Contributors - [`@​jiahaoliang](https://togithub.com/jiahaoliang)` made their first contribution in [https://github.com/hyperium/hyper/pull/3006](https://togithub.com/hyperium/hyper/pull/3006) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/OpenPoolProject/stratum). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTkuNSIsInVwZGF0ZWRJblZlciI6IjM0LjExOS41In0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
bors bot
referenced
this pull request
in TeamHarTex/HarTex
Feb 2, 2023
602: Update Rust crate hyper to 0.14.24 r=HTG-YT a=renovate[bot] [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [hyper](https://hyper.rs) ([source](https://togithub.com/hyperium/hyper)) | dependencies | patch | `0.14.23` -> `0.14.24` | --- ### Release Notes <details> <summary>hyperium/hyper</summary> ### [`v0.14.24`](https://togithub.com/hyperium/hyper/releases/tag/v0.14.24) [Compare Source](https://togithub.com/hyperium/hyper/compare/v0.14.23...v0.14.24) #### Bug Fixes - **body:** set an internal max to reserve in `to_bytes` ([4d89adce](https://togithub.com/hyperium/hyper/commit/4d89adce6122af1650165337d9d814314e7ee409)) - **server:** prevent sending 100-continue if user drops request body ([#​3138](https://togithub.com/hyperium/hyper/issues/3138)) ([92443d7e](https://togithub.com/hyperium/hyper/commit/92443d7ef57ed474f0add7dd1f114c81a3faa8fe)) #### Features - **http2:** add `http2_max_header_list_size` to `hyper::server::Builder` ([#​3006](https://togithub.com/hyperium/hyper/issues/3006)) ([031425f0](https://togithub.com/hyperium/hyper/commit/031425f087219f02a87eea3d01b14e75e35a5209)) #### New Contributors - [`@​jiahaoliang](https://togithub.com/jiahaoliang)` made their first contribution in [https://github.com/hyperium/hyper/pull/3006](https://togithub.com/hyperium/hyper/pull/3006) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/TeamHarTex/HarTex). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTkuNSIsInVwZGF0ZWRJblZlciI6IjM0LjExOS41In0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
trunk-io bot
referenced
this pull request
in hashintel/hash
Feb 19, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [hyper](https://hyper.rs) ([source](https://togithub.com/hyperium/hyper)) | dependencies | patch | `0.14.23` -> `0.14.24` | --- ### Release Notes <details> <summary>hyperium/hyper</summary> ### [`v0.14.24`](https://togithub.com/hyperium/hyper/releases/tag/v0.14.24) [Compare Source](https://togithub.com/hyperium/hyper/compare/v0.14.23...v0.14.24) #### Bug Fixes - **body:** set an internal max to reserve in `to_bytes` ([4d89adce](https://togithub.com/hyperium/hyper/commit/4d89adce6122af1650165337d9d814314e7ee409)) - **server:** prevent sending 100-continue if user drops request body ([#​3138](https://togithub.com/hyperium/hyper/issues/3138)) ([92443d7e](https://togithub.com/hyperium/hyper/commit/92443d7ef57ed474f0add7dd1f114c81a3faa8fe)) #### Features - **http2:** add `http2_max_header_list_size` to `hyper::server::Builder` ([#​3006](https://togithub.com/hyperium/hyper/issues/3006)) ([031425f0](https://togithub.com/hyperium/hyper/commit/031425f087219f02a87eea3d01b14e75e35a5209)) #### New Contributors - [@​jiahaoliang](https://togithub.com/jiahaoliang) made their first contribution in [https://github.com/hyperium/hyper/pull/3006](https://togithub.com/hyperium/hyper/pull/3006) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/hashintel/hash). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNDMuMSIsInVwZGF0ZWRJblZlciI6IjM0LjE0My4xIn0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix incomplete changes introduced from #2828