h2: add max_pending_accept_reset_streams configuration option #3201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noah-Kennedy
force-pushed
the
noah/h2-resets
branch
from
2c6ac9d to
8be5245
Compare
LPardue
reviewed
Apr 13, 2023
nox
reviewed
Apr 13, 2023
This allows users to set the configuration option from hyperium/h2#668.
Noah-Kennedy
force-pushed
the
noah/h2-resets
branch
from
8be5245 to
7a0145e
Compare
hawkw
reviewed
Apr 13, 2023
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
|
@hawkw I've addressed your feedback |
|
Does it seem likely people want to configure this on the client? I'm guessing since hyper disables server push, there's nothing to worry about? |
I don't think we need client configuration for now, if someone asks then we can add it IMO. |
|
Like you said, we don't support server push anyways for the client. |
hawkw
approved these changes
Apr 13, 2023
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
|
I committed your suggestions |
seanmonstar
approved these changes
Apr 13, 2023
bors bot
referenced
this pull request
in TeamHarTex/HarTex
Apr 14, 2023
771: Update Rust crate hyper to 0.14.26 r=HTG-YT a=renovate[bot] [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [hyper](https://hyper.rs) ([source](https://togithub.com/hyperium/hyper)) | dependencies | patch | `0.14.25` -> `0.14.26` | --- ### Release Notes <details> <summary>hyperium/hyper</summary> ### [`v0.14.26`](https://togithub.com/hyperium/hyper/releases/tag/v0.14.26) [Compare Source](https://togithub.com/hyperium/hyper/compare/v0.14.25...v0.14.26) #### Features - **http2:** add `max_pending_accept_reset_streams` configuration option ([#​3201](https://togithub.com/hyperium/hyper/issues/3201)) ([a6f7571a](https://togithub.com/hyperium/hyper/commit/a6f7571a5299793aef8f1aa4194574438b9df64c)) #### New Contributors - [`@​Noah-Kennedy](https://togithub.com/Noah-Kennedy)` made their first contribution in [https://github.com/hyperium/hyper/pull/3201](https://togithub.com/hyperium/hyper/pull/3201) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/TeamHarTex/HarTex). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40MC4wIiwidXBkYXRlZEluVmVyIjoiMzUuNDAuMCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
cratelyn
added a commit
to cratelyn/hyper
that referenced
this pull request
Nov 27, 2024
](https://renovatebot.com){kind=link}
…builder NB: this commit is based on the `0.14.x` release series. the `server::conn::http2` submodule provides types that are conditionally compiled when the `backports` feature is active, to facilitate upgrading to the `1.x` release. i've been working on upgrading the [`linkerd2-proxy`](https://github.com/linkerd/linkerd2-proxy/) project to use hyper 1.0, but encountered some gaps in `Builder<E>`'s interface when setting the `backports` and `deprecated` features. this adds a `max_pending_accept_reset_streams(..)` method (_added in #3201_) to this builder, so that 0.14.x users relying on this functionality can prepare to upgrade to hyper 1.x safely. this is effectively a backport of hyperium#3507, which restored this interface to the 1.0 release. for more information, see: * hyperium#3201 * hyperium#3507 * hyperium#3461 * https://hyper.rs/guides/1/upgrading/ Signed-off-by: katelyn martin <me+cratelyn@katelyn.world>
cratelyn
added a commit
to cratelyn/hyper
that referenced
this pull request
Nov 27, 2024
…builder NB: this commit is based on the `0.14.x` release series. the `server::conn::http2` submodule provides types that are conditionally compiled when the `backports` feature is active, to facilitate upgrading to the `1.x` release. i've been working on upgrading the [`linkerd2-proxy`](https://github.com/linkerd/linkerd2-proxy/) project to use hyper 1.0, but encountered some gaps in `Builder<E>`'s interface when setting the `backports` and `deprecated` features. this adds a `max_pending_accept_reset_streams(..)` method (_added in #3201_) to this builder, so that 0.14.x users relying on this functionality can prepare to upgrade to hyper 1.x safely. this is effectively a backport of hyperium#3507, which restored this interface to the 1.0 release. for more information, see: * hyperium#3201 * hyperium#3507 * hyperium#3461 * https://hyper.rs/guides/1/upgrading/ Signed-off-by: katelyn martin <me+cratelyn@katelyn.world>
seanmonstar
pushed a commit
that referenced
this pull request
Nov 29, 2024
#3796) the `server::conn::http2` submodule provides types that are conditionally compiled when the `backports` feature is active, to facilitate upgrading to the `1.x` release. i've been working on upgrading the [`linkerd2-proxy`](https://github.com/linkerd/linkerd2-proxy/) project to use hyper 1.0, but encountered some gaps in `Builder<E>`'s interface when setting the `backports` and `deprecated` features. this adds a `max_pending_accept_reset_streams(..)` method (_added in #3201_) to this builder, so that 0.14.x users relying on this functionality can prepare to upgrade to hyper 1.x safely. this is effectively a backport of #3507, which restored this interface to the 1.0 release. for more information, see: * #3201 * #3507 * #3461 * https://hyper.rs/guides/1/upgrading/ Signed-off-by: katelyn martin <me+cratelyn@katelyn.world>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to set the configuration option from hyperium/h2#668.