Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): reduce default dependencies #3327

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Sep 28, 2023

httpdate and want are used in some combinations of features. Although Cargo does not provide such a combined features configuration, the scopes could be reduced.

Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(Now I wonder, is there a CI job we could setup to catch these?)

@seanmonstar seanmonstar merged commit a6dbda1 into hyperium:master Sep 28, 2023
18 checks passed
@tottoto tottoto deleted the reduce-default-dependencies branch September 29, 2023 03:36
@tottoto
Copy link
Contributor Author

tottoto commented Sep 29, 2023

cargo-udeps can handle feature aware checking. For hyper's default and full feature, it can be checked with cargo-udeps (like tonic project, in this ci, tonic checks each feature with cargo-hack). Regarding the another features, as hyper uses some crates in the combination of multiple feature, it seem not to be able to achieve minimal dependencies for any possible features combination.

@tottoto
Copy link
Contributor Author

tottoto commented Oct 3, 2023

Opend #3334 to check unused dependencies.

0xE282B0 pushed a commit to 0xE282B0/hyper that referenced this pull request Jan 12, 2024
0xE282B0 pushed a commit to 0xE282B0/hyper that referenced this pull request Jan 16, 2024
Signed-off-by: Sven Pfennig <s.pfennig@reply.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants