ping: eliminates unnecessary ping when the connection is idle. #3381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I understand the bug. The problem is that a ping was scheduled while the connection was busy (not idle), but then streams finished, and the timer fires and wants to send a ping, but then it shouldn't send the ping. Is that right? Have you tried out this patch in your workflow? |
Yes, I think this is the root cause.
Yes, I have tried this patch, and it did not meet the error |
seanmonstar
approved these changes
Nov 2, 2023
0xE282B0
pushed a commit
to 0xE282B0/hyper
that referenced
this pull request
Jan 12, 2024
Signed-off-by: husharp <jinhao.hu@pingcap.com>
0xE282B0
pushed a commit
to 0xE282B0/hyper
that referenced
this pull request
Jan 16, 2024
Signed-off-by: husharp <jinhao.hu@pingcap.com> Signed-off-by: Sven Pfennig <s.pfennig@reply.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3380
rely on https://pkg.go.dev/google.golang.org/grpc/keepalive
server-side will output
too many pings