Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): add missing without_shutdown method #3431

Merged

Conversation

kiron1
Copy link
Contributor

@kiron1 kiron1 commented Nov 20, 2023

in client::conn::http1::Connection the method poll_without_shutdown references without_shutdown in its documentation, but the method without_shutdown is not present in the code. This PR copies without_shutdown from hyper 0.14.x: https://github.com/hyperium/hyper/blob/0.14.x/src/client/conn.rs#L520-L528

@kiron1 kiron1 force-pushed the hyper-0.14.x-client-without_shutdown branch from 55c5e41 to a13511c Compare November 20, 2023 08:52
@kiron1 kiron1 force-pushed the hyper-0.14.x-client-without_shutdown branch from a13511c to b711843 Compare November 20, 2023 09:10
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@seanmonstar seanmonstar merged commit ad50497 into hyperium:0.14.x Nov 20, 2023
19 checks passed
@kiron1 kiron1 deleted the hyper-0.14.x-client-without_shutdown branch November 22, 2023 00:37
@kiron1 kiron1 restored the hyper-0.14.x-client-without_shutdown branch November 22, 2023 01:32
@kiron1 kiron1 deleted the hyper-0.14.x-client-without_shutdown branch November 22, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants