Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(http1): reject chunked headers missing a digit #3494

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

seanmonstar
Copy link
Member

Previously, hyper would decode \r\n\r\n as 0\r\n\r\n. This fixes hyper to require a digit to be present before starting at 0.

Reported-by: Ben Kallus benjamin.p.kallus.gr@dartmouth.edu

Previously, hyper would decode `\r\n\r\n` as `0\r\n\r\n`. This fixes
hyper to require a digit to be present before starting at 0.

Reported-by: Ben Kallus <benjamin.p.kallus.gr@dartmouth.edu>
@seanmonstar seanmonstar merged commit 8291538 into master Dec 18, 2023
21 checks passed
@seanmonstar seanmonstar deleted the fix-chunked-missing-digit branch December 18, 2023 13:42
seanmonstar added a commit that referenced this pull request Dec 18, 2023
Previously, hyper would decode `\r\n\r\n` as `0\r\n\r\n`. This fixes
hyper to require a digit to be present before starting at 0.

Reported-by: Ben Kallus <benjamin.p.kallus.gr@dartmouth.edu>
seanmonstar added a commit that referenced this pull request Dec 18, 2023
Previously, hyper would decode `\r\n\r\n` as `0\r\n\r\n`. This fixes
hyper to require a digit to be present before starting at 0.

Reported-by: Ben Kallus <benjamin.p.kallus.gr@dartmouth.edu>
0xE282B0 pushed a commit to 0xE282B0/hyper that referenced this pull request Jan 12, 2024
Previously, hyper would decode `\r\n\r\n` as `0\r\n\r\n`. This fixes
hyper to require a digit to be present before starting at 0.

Reported-by: Ben Kallus <benjamin.p.kallus.gr@dartmouth.edu>
0xE282B0 pushed a commit to 0xE282B0/hyper that referenced this pull request Jan 16, 2024
Previously, hyper would decode `\r\n\r\n` as `0\r\n\r\n`. This fixes
hyper to require a digit to be present before starting at 0.

Reported-by: Ben Kallus <benjamin.p.kallus.gr@dartmouth.edu>
Signed-off-by: Sven Pfennig <s.pfennig@reply.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant