Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Future implementation on Connection unconditional on executor being Send + Sync. #3682

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

mstyura
Copy link
Contributor

@mstyura mstyura commented Jun 5, 2024

This PR is created to raise the question if Future implementation on Connection is mandatory to request Executor to be Send + Sync.
Question initially raised here https://discord.com/channels/500028886025895936/670880858630258689/1247563996068970557.

@mstyura
Copy link
Contributor Author

mstyura commented Jun 7, 2024

Interesting, CI does rustfmt --edition 2021 $(git ls-files '*.rs') and it formats code, while cargo fmt does not.

@seanmonstar
Copy link
Member

I think this looks good, any reason it was marked a draft?

@mstyura
Copy link
Contributor Author

mstyura commented Jun 25, 2024

It was initially supposed to raise a question, that's why I've marked it as draft. But as long as you are ok with changes I will unmask as draft and fix issues if any according to review

@mstyura mstyura marked this pull request as ready for review June 25, 2024 18:05
@seanmonstar seanmonstar merged commit 56c3cd5 into hyperium:master Jul 1, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants