Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(headers): Introduce header!() macro, improve documentation #419

Merged
merged 1 commit into from
Apr 2, 2015
Merged

refactor(headers): Introduce header!() macro, improve documentation #419

merged 1 commit into from
Apr 2, 2015

Conversation

pyfisch
Copy link
Contributor

@pyfisch pyfisch commented Apr 2, 2015

The new macro handles single value headers, list headers, and list
headers with at least one item.
It creates the item for the header and contains its documentation. The
new macro allows handling
more header cases in the future, it will also be possible to include
tests inside the macro.

BREAKING_CHANGE: Removed impl_header!() and impl_list_header!() macros,
use new header!() macro.

@pyfisch
Copy link
Contributor Author

pyfisch commented Apr 2, 2015

By the way, the documentation syntax will get better once rust-lang/rust#23812 gets fixed.

@seanmonstar
Copy link
Member

Sweet! And also, the change in docs: wtf. (I know it's not your fault).

@seanmonstar
Copy link
Member

Oh, also, the commit syntax is actually BREAKING CHANGE:, without the underscore.

The new macro handles single value headers, list headers, and list
headers with at least one item.
It creates the item for the header and contains its documentation. The
new macro allows handling
more header cases in the future, it will also be possible to include
tests inside the macro.

BREAKING CHANGE: Removed impl_header!() and impl_list_header!() macros,
use new header!() macro.
@pyfisch
Copy link
Contributor Author

pyfisch commented Apr 2, 2015

Thanks, fixed.

seanmonstar added a commit that referenced this pull request Apr 2, 2015
refactor(headers): Introduce header!() macro, improve documentation
@seanmonstar seanmonstar merged commit b4aeeb3 into hyperium:master Apr 2, 2015
@pyfisch pyfisch deleted the refactorheaders1 branch April 7, 2015 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants