fix(client): keep the underlying connector when setting an SSL verifier #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit includes an implementation of the new trait method for all existing trait impls. BREAKING CHANGE: Adding a new required method to a public trait is a breaking change.
The client no longer drops the old `Connector` instance, along with its entire context (such as the settings and pooled connections in the case of a `Pool` connector); rather, it passes the SSL verifier on to the `Connector` so that it uses it for any future connections that it needs to establish. A regression test is included. Closes hyperium#495
mlalic
force-pushed
the
fix-client-ssl-verifier
branch
from
4988060 to
f4556d5
Compare
|
Excellent, thank you! |
seanmonstar
added a commit
that referenced
this pull request
May 10, 2015
fix(client): keep the underlying connector when setting an SSL verifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client no longer drops the old
Connectorinstance, along with itsentire context (such as the settings and pooled connections in the case
of a
Poolconnector); rather, it passes the SSL verifier on to theConnectorso that it uses it for any future connections that it needsto establish.
A regression test is included.
Closes #495