Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): dont call close() inside Request #520

Merged
merged 1 commit into from
May 10, 2015
Merged

fix(client): dont call close() inside Request #520

merged 1 commit into from
May 10, 2015

Conversation

seanmonstar
Copy link
Member

Only call close() in the Response, which should already return a
responding Connection: close.

Closes #519

@seanmonstar
fix(client): dont call close() inside Request
3334fca 
Only call close() in the Response, which should already return a
responding `Connection: close`.

Closes #519
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 85.47% when pulling 3334fca on conn-close into a3637d5 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 85.47% when pulling 3334fca on conn-close into a3637d5 on master.

seanmonstar added a commit that referenced this pull request May 10, 2015
@seanmonstar
Merge pull request #520 from hyperium/conn-close
390b9fa 
fix(client): dont call close() inside Request
@seanmonstar seanmonstar merged commit 390b9fa into master May 10, 2015
@seanmonstar seanmonstar deleted the conn-close branch May 10, 2015 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hyper client after v0.3.15 can't connect to some nginx servers with ConnectionOption::Close
2 participants
@seanmonstar @coveralls