Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(net): add net2 crate and TcpBuilderConnector #618

Closed
wants to merge 1 commit into from

Conversation

muja
Copy link

@muja muja commented Jul 25, 2015

Use net2 crate that implements RFC#1158.

Fixes #602

@seanmonstar
Copy link
Member

Ah bummer, I didn't notice that the net2 crate uses an unstable feature. This prevents me from merging this in hyper as-is. I could consider a possible cargo feature flag to include this, but the best would be to stabilize duration in libstd.

@GitCop
Copy link

GitCop commented Jul 28, 2015

Thanks for contributing! Unfortunately, I'm here to tell you there were the following style issues with your Pull Request:

  • Commit: 16f5358
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at https://github.com/hyperium/hyper/blob/master/CONTRIBUTING.md


This message was auto-generated by https://gitcop.com

@seanmonstar
Copy link
Member

I'm going to close this, since the better #622 was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants