Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HeapSizeOf support. #30

Closed
wants to merge 1 commit into from
Closed

Conversation

notriddle
Copy link

Part of servo/heapsize#5.

@seanmonstar
Copy link
Member

I'm not sure about this one. This seems quite specific, and adding
"features" like this just increases the maintenance burden.

Can it not be implemented in servo itself?

On Sat, Oct 24, 2015, 9:28 PM Michael Howell notifications@github.com
wrote:

Part of servo/heapsize#5 servo/heapsize#5.

You can view, comment on, or merge this pull request online at:

#30
Commit Summary

  • Add HeapSizeOf support.

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#30.

@notriddle
Copy link
Author

Not well. It's not possible to #[derive(HeapSizeOf)] from an outside
crate, especially since you can't necessarily access every heap-allocated
member variable. Notice the hacks we're using for things in libstd.

On Sun, Oct 25, 2015, 08:09 Sean McArthur notifications@github.com wrote:

I'm not sure about this one. This seems quite specific, and adding
"features" like this just increases the maintenance burden.

Can it not be implemented in servo itself?

On Sat, Oct 24, 2015, 9:28 PM Michael Howell notifications@github.com
wrote:

Part of servo/heapsize#5 servo/heapsize#5.

You can view, comment on, or merge this pull request online at:

#30
Commit Summary

  • Add HeapSizeOf support.

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#30.


Reply to this email directly or view it on GitHub
#30 (comment).

@notriddle notriddle closed this Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants