Skip to content
This repository has been archived by the owner on Jul 10, 2023. It is now read-only.

Implement heapsize for all the libraries servo uses #5

Closed
8 of 13 tasks
notriddle opened this issue Aug 9, 2015 · 7 comments
Closed
8 of 13 tasks

Implement heapsize for all the libraries servo uses #5

notriddle opened this issue Aug 9, 2015 · 7 comments

Comments

@notriddle
Copy link
Contributor

These are all the libraries that had HeapSizeOf definitions in components/util:

@jdm
Copy link
Member

jdm commented Aug 9, 2015

I am keen to add hyper support, too.

notriddle added a commit to notriddle/rust-azure that referenced this issue Aug 9, 2015
@Manishearth
Copy link
Member

Should we advertise this library as something for the general community to use?

@SimonSapin
Copy link
Member

@nnethercote suggests moving it into std so that std types can implement it in less hackish ways (e.g. getting a pointer from a private field): #1 (comment)

@Manishearth
Copy link
Member

I'm not sure if that will happen -- even the regex lib (arguably more useful) is not part of std.

Post-MIR we may be able to generalize derive so it can be applied to crates preceding the one defining the trait via metadata (not sure if private fields will work).

@SimonSapin
Copy link
Member

The argument is not that it’s more useful, but that implementing it for std types outside of std (so without access to private fields) requires guessing or crazy unsafe code.

@Manishearth
Copy link
Member

Sure, but that just makes a case for why this should be in std, not for why std would want this 😄

@jdm
Copy link
Member

jdm commented Aug 9, 2015

std is the ideal here, but I'd like further experience making use of it in the wider world before committing to the RFC process.

notriddle added a commit to notriddle/string-cache that referenced this issue Aug 9, 2015
notriddle added a commit to notriddle/rust-azure that referenced this issue Aug 10, 2015
notriddle added a commit to notriddle/string-cache that referenced this issue Aug 10, 2015
notriddle added a commit to notriddle/rust-selectors that referenced this issue Aug 10, 2015
notriddle added a commit to notriddle/rust-selectors that referenced this issue Aug 10, 2015
bors-servo pushed a commit to servo/rust-azure that referenced this issue Aug 11, 2015
Add heapsize support.

Part of servo/heapsize#5.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-azure/193)
<!-- Reviewable:end -->
bors-servo pushed a commit to servo/rust-cssparser that referenced this issue Aug 13, 2015
Add HeapSizeOf support.

Part of servo/heapsize#5.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/85)
<!-- Reviewable:end -->
bors-servo pushed a commit to servo/rust-url that referenced this issue Aug 13, 2015
Add heapsize support.

Part of servo/heapsize#5.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/123)
<!-- Reviewable:end -->
bors-servo pushed a commit to servo/string-cache that referenced this issue Aug 13, 2015
derive(HeapSizeOf).

Part of servo/heapsize#5.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/string-cache/105)
<!-- Reviewable:end -->
notriddle added a commit to notriddle/rust-selectors that referenced this issue Aug 13, 2015
notriddle added a commit to notriddle/rust-mozjs that referenced this issue Aug 13, 2015
bors-servo pushed a commit to servo/rust-mozjs that referenced this issue Aug 13, 2015
Add `HeapSizeOf` implementation.

Part of servo/heapsize#5.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/187)
<!-- Reviewable:end -->
notriddle added a commit to notriddle/euclid that referenced this issue Aug 14, 2015
bors-servo pushed a commit to servo/euclid that referenced this issue Aug 23, 2015
Add `HeapSizeOf` implementation.

Part of servo/heapsize#5.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/euclid/99)
<!-- Reviewable:end -->
notriddle added a commit to notriddle/rust-selectors that referenced this issue Oct 18, 2015
notriddle added a commit to notriddle/html5ever that referenced this issue Oct 18, 2015
bors-servo pushed a commit to servo/rust-selectors that referenced this issue Oct 18, 2015
Add `HeapSizeOf` support.

Part of servo/heapsize#5.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-selectors/51)
<!-- Reviewable:end -->
bors-servo pushed a commit to servo/html5ever that referenced this issue Oct 18, 2015
Add `HeapSizeOf` support.

Part of Part of servo/heapsize#5.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/html5ever/177)
<!-- Reviewable:end -->
notriddle added a commit to notriddle/html5ever that referenced this issue Oct 19, 2015
bors-servo pushed a commit to servo/html5ever that referenced this issue Oct 25, 2015
Add `HeapSizeOf` support.

Part of Part of servo/heapsize#5.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/html5ever/177)
<!-- Reviewable:end -->
notriddle added a commit to notriddle/hyper that referenced this issue Oct 25, 2015
notriddle added a commit to notriddle/mime.rs that referenced this issue Oct 25, 2015
notriddle added a commit to notriddle/mime.rs that referenced this issue Oct 25, 2015
notriddle added a commit to notriddle/mime.rs that referenced this issue Oct 25, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants