chore: Rename Status to_http method to into_http (#1719)

hyperium · Jun 12, 2024 · 3e5cd1e · 3e5cd1e
1 parent ed95d27
commit 3e5cd1e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/tonic/src/server/grpc.rs b/tonic/src/server/grpc.rs
@@ -15,7 +15,7 @@ macro_rules! t {
     ($result:expr) => {
         match $result {
             Ok(value) => value,
-            Err(status) => return status.to_http(),
+            Err(status) => return status.into_http(),
         }
     };
 }

diff --git a/tonic/src/service/interceptor.rs b/tonic/src/service/interceptor.rs
@@ -219,7 +219,7 @@ where
                 let response = status
                     .take()
                     .unwrap()
-                    .to_http()
+                    .into_http()
                     .map(|_| B::default())
                     .map(boxed);
                 Poll::Ready(Ok(response))
@@ -288,7 +288,7 @@ mod tests {
     #[tokio::test]
     async fn handles_intercepted_status_as_response() {
         let message = "Blocked by the interceptor";
-        let expected = Status::permission_denied(message).to_http();
+        let expected = Status::permission_denied(message).into_http();
 
         let svc = tower::service_fn(|_: http::Request<TestBody>| async {
             Ok::<_, Status>(http::Response::new(TestBody))

diff --git a/tonic/src/status.rs b/tonic/src/status.rs
@@ -580,9 +580,8 @@ impl Status {
         self
     }
 
-    #[allow(clippy::wrong_self_convention)]
     /// Build an `http::Response` from the given `Status`.
-    pub fn to_http(self) -> http::Response<BoxBody> {
+    pub fn into_http(self) -> http::Response<BoxBody> {
         let mut response = http::Response::new(crate::body::empty_body());
         response.headers_mut().insert(
             http::header::CONTENT_TYPE,