feedback, clean up straggler changes

examples/src/json-codec/common.rs

@@ -30,10 +30,6 @@ impl<T: serde::Serialize> Encoder for JsonEncoder<T> {
     fn encode(&mut self, item: Self::Item, buf: &mut EncodeBuf<'_>) -> Result<(), Self::Error> {
         serde_json::to_writer(buf.writer(), &item).map_err(|e| Status::internal(e.to_string()))
     }
-
-    fn buffer_settings(&self) -> tonic::codec::BufferSettings {
-        Default::default()
-    }
 }
 
 #[derive(Debug)]
@@ -52,10 +48,6 @@ impl<U: serde::de::DeserializeOwned> Decoder for JsonDecoder<U> {
             serde_json::from_reader(buf.reader()).map_err(|e| Status::internal(e.to_string()))?;
         Ok(Some(item))
     }
-
-    fn buffer_settings(&self) -> tonic::codec::BufferSettings {
-        Default::default()
-    }
 }
 
 /// A [`Codec`] that implements `application/grpc+json` via the serde library.

tonic-build/src/client.rs

@@ -221,7 +221,7 @@ fn generate_unary<T: Service>(
     proto_path: &str,
     compile_well_known_types: bool,
 ) -> TokenStream {
-    let codec_name = syn::parse_str::<syn::Path>(&method.codec_path()).unwrap();
+    let codec_name = syn::parse_str::<syn::Path>(method.codec_path()).unwrap();
     let ident = format_ident!("{}", method.name());
     let (request, response) = method.request_response_name(proto_path, compile_well_known_types);
     let service_name = format_service_name(service, emit_package);
@@ -252,7 +252,7 @@ fn generate_server_streaming<T: Service>(
     proto_path: &str,
     compile_well_known_types: bool,
 ) -> TokenStream {
-    let codec_name = syn::parse_str::<syn::Path>(&method.codec_path()).unwrap();
+    let codec_name = syn::parse_str::<syn::Path>(method.codec_path()).unwrap();
     let ident = format_ident!("{}", method.name());
     let (request, response) = method.request_response_name(proto_path, compile_well_known_types);
     let service_name = format_service_name(service, emit_package);
@@ -283,7 +283,7 @@ fn generate_client_streaming<T: Service>(
     proto_path: &str,
     compile_well_known_types: bool,
 ) -> TokenStream {
-    let codec_name = syn::parse_str::<syn::Path>(&method.codec_path()).unwrap();
+    let codec_name = syn::parse_str::<syn::Path>(method.codec_path()).unwrap();
     let ident = format_ident!("{}", method.name());
     let (request, response) = method.request_response_name(proto_path, compile_well_known_types);
     let service_name = format_service_name(service, emit_package);
@@ -314,7 +314,7 @@ fn generate_streaming<T: Service>(
     proto_path: &str,
     compile_well_known_types: bool,
 ) -> TokenStream {
-    let codec_name = syn::parse_str::<syn::Path>(&method.codec_path()).unwrap();
+    let codec_name = syn::parse_str::<syn::Path>(method.codec_path()).unwrap();
     let ident = format_ident!("{}", method.name());
     let (request, response) = method.request_response_name(proto_path, compile_well_known_types);
     let service_name = format_service_name(service, emit_package);

tonic-build/src/compile_settings.rs

@@ -1,11 +1,13 @@
 #[derive(Debug, Clone)]
 pub(crate) struct CompileSettings {
+    #[cfg(feature = "prost")]
     pub(crate) codec_path: String,
 }
 
 impl Default for CompileSettings {
     fn default() -> Self {
         Self {
+            #[cfg(feature = "prost")]
             codec_path: "tonic::codec::ProstCodec".to_string(),
         }
     }

tonic-build/src/lib.rs

@@ -98,7 +98,6 @@ mod code_gen;
 pub use code_gen::CodeGenBuilder;
 
 mod compile_settings;
-pub(crate) use compile_settings::CompileSettings;
 
 /// Service generation trait.
 ///

tonic-build/src/prost.rs

@@ -1,4 +1,4 @@
-use crate::{code_gen::CodeGenBuilder, CompileSettings};
+use crate::{code_gen::CodeGenBuilder, compile_settings::CompileSettings};
 
 use super::Attributes;
 use proc_macro2::TokenStream;

tonic-build/src/server.rs

@@ -457,7 +457,7 @@ fn generate_unary<T: Method>(
     server_trait: Ident,
     use_arc_self: bool,
 ) -> TokenStream {
-    let codec_name = syn::parse_str::<syn::Path>(&method.codec_path()).unwrap();
+    let codec_name = syn::parse_str::<syn::Path>(method.codec_path()).unwrap();
 
     let service_ident = quote::format_ident!("{}Svc", method.identifier());
 
@@ -517,7 +517,7 @@ fn generate_server_streaming<T: Method>(
     use_arc_self: bool,
     generate_default_stubs: bool,
 ) -> TokenStream {
-    let codec_name = syn::parse_str::<syn::Path>(&method.codec_path()).unwrap();
+    let codec_name = syn::parse_str::<syn::Path>(method.codec_path()).unwrap();
 
     let service_ident = quote::format_ident!("{}Svc", method.identifier());
 
@@ -587,7 +587,7 @@ fn generate_client_streaming<T: Method>(
     let service_ident = quote::format_ident!("{}Svc", method.identifier());
 
     let (request, response) = method.request_response_name(proto_path, compile_well_known_types);
-    let codec_name = syn::parse_str::<syn::Path>(&method.codec_path()).unwrap();
+    let codec_name = syn::parse_str::<syn::Path>(method.codec_path()).unwrap();
 
     let inner_arg = if use_arc_self {
         quote!(inner)
@@ -644,7 +644,7 @@ fn generate_streaming<T: Method>(
     use_arc_self: bool,
     generate_default_stubs: bool,
 ) -> TokenStream {
-    let codec_name = syn::parse_str::<syn::Path>(&method.codec_path()).unwrap();
+    let codec_name = syn::parse_str::<syn::Path>(method.codec_path()).unwrap();
 
     let service_ident = quote::format_ident!("{}Svc", method.identifier());
 

tonic/benches/decode.rs

@@ -105,10 +105,6 @@ impl Decoder for MockDecoder {
         buf.advance(self.message_size);
         Ok(Some(out))
     }
-
-    fn buffer_settings(&self) -> tonic::codec::BufferSettings {
-        Default::default()
-    }
 }
 
 fn make_payload(message_length: usize, message_count: usize) -> Bytes {

tonic/src/codec/mod.rs

@@ -36,7 +36,7 @@ const DEFAULT_YIELD_THRESHOLD: usize = 32 * 1024;
 /// Buffer size defaults to 8KiB.
 ///
 /// Example:
-/// ```
+/// ```ignore
 /// Buffer start:       | 8kb |
 /// Message received:   |   24612 bytes    |
 /// Buffer grows:       | 8kb | 8kb | 8kb | 8kb |