fix(codec): Enforce encoders/decoders are Sync

Closes #81
hyperium · Oct 21, 2019 · 8317a8c · 8317a8c
1 parent 5d0a795
commit 8317a8c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/tonic/src/codec/decode.rs b/tonic/src/codec/decode.rs
@@ -19,7 +19,7 @@ const BUFFER_SIZE: usize = 8 * 1024;
 /// This will wrap some inner [`Body`] and [`Decoder`] and provide an interface
 /// to fetch the message stream and trailing metadata
 pub struct Streaming<T> {
-    decoder: Box<dyn Decoder<Item = T, Error = Status> + Send + 'static>,
+    decoder: Box<dyn Decoder<Item = T, Error = Status> + Sync + Send + 'static>,
     body: BoxBody,
     state: State,
     direction: Direction,
@@ -48,7 +48,7 @@ impl<T> Streaming<T> {
         B: Body + Send + 'static,
         B::Data: Into<Bytes>,
         B::Error: Into<crate::Error>,
-        D: Decoder<Item = T, Error = Status> + Send + 'static,
+        D: Decoder<Item = T, Error = Status> + Sync + Send + 'static,
     {
         Self::new(decoder, body, Direction::Response(status_code))
     }
@@ -58,7 +58,7 @@ impl<T> Streaming<T> {
         B: Body + Send + 'static,
         B::Data: Into<Bytes>,
         B::Error: Into<crate::Error>,
-        D: Decoder<Item = T, Error = Status> + Send + 'static,
+        D: Decoder<Item = T, Error = Status> + Sync + Send + 'static,
     {
         Self::new(decoder, body, Direction::EmptyResponse)
     }
@@ -68,7 +68,7 @@ impl<T> Streaming<T> {
         B: Body + Send + 'static,
         B::Data: Into<Bytes>,
         B::Error: Into<crate::Error>,
-        D: Decoder<Item = T, Error = Status> + Send + 'static,
+        D: Decoder<Item = T, Error = Status> + Sync + Send + 'static,
     {
         Self::new(decoder, body, Direction::Request)
     }
@@ -78,7 +78,7 @@ impl<T> Streaming<T> {
         B: Body + Send + 'static,
         B::Data: Into<Bytes>,
         B::Error: Into<crate::Error>,
-        D: Decoder<Item = T, Error = Status> + Send + 'static,
+        D: Decoder<Item = T, Error = Status> + Sync + Send + 'static,
     {
         Self {
             decoder: Box::new(decoder),

diff --git a/tonic/src/codec/mod.rs b/tonic/src/codec/mod.rs
@@ -28,9 +28,9 @@ pub trait Codec {
     type Decode: Send + 'static;
 
     /// The encoder that can encode a message.
-    type Encoder: Encoder<Item = Self::Encode, Error = Status> + Send + 'static;
+    type Encoder: Encoder<Item = Self::Encode, Error = Status> + Sync + Send + 'static;
     /// The encoder that can decode a message.
-    type Decoder: Decoder<Item = Self::Decode, Error = Status> + Send + 'static;
+    type Decoder: Decoder<Item = Self::Decode, Error = Status> + Sync + Send + 'static;
 
     /// The content type of this codec.
     ///