Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document tonic-build configure method #118

Closed
blittable opened this issue Nov 5, 2019 · 3 comments
Closed

document tonic-build configure method #118

blittable opened this issue Nov 5, 2019 · 3 comments
Labels
A-build E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue. T-docs Improvements or additions to documentation

Comments

@blittable
Copy link
Contributor

blittable commented Nov 5, 2019 •
edited
Loading

On: tonic-build v0.1.0-alpha.5 (/code/tonic/tonic-build)

We need api doc.

This method is also helpful for diagnosing protobuf build issues - (pb namespace, permissions, rustfmt, toolchain, config, etc.)

https://docs.rs/tonic-build/0.1.0-alpha.5/tonic_build/fn.configure.html

tonic/tonic-build/src/lib.rs

Line 166 in 23f648b

/// Configure tonic-build code generation.

@blittable
Copy link
Contributor Author

#102

@LucioFranco
Copy link
Member

@blittable maybe im missing something, but is the api not documented? I assume you mean we should improve its documentation?

@blittable
Copy link
Contributor Author

blittable commented Nov 5, 2019 •
edited
Loading

Maybe a sample on that link with the additional configuration options? (Like out_dir)

Eeee.. It’s on the Builder... scratch that

@LucioFranco LucioFranco added A-build T-docs Improvements or additions to documentation E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue. labels Nov 5, 2019
@akiradeveloper akiradeveloper mentioned this issue Aug 3, 2022
Closed
brentalanmiller pushed a commit to brentalanmiller/tonic that referenced this issue Oct 6, 2023
@djc
Clippy fixes (hyperium#118)
c033514
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-build E-easy Call for participation: Experience needed to fix: Easy / not much E-help-wanted Call for participation: Help is requested to fix this issue. T-docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LucioFranco @blittable