Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tonic::Interceptor is not unwind safe #429

Closed
tobz opened this issue Aug 16, 2020 · 2 comments · Fixed by #641
Closed

tonic::Interceptor is not unwind safe #429

tobz opened this issue Aug 16, 2020 · 2 comments · Fixed by #641
Labels
A-tonic C-bug Category: Something isn't working E-help-wanted Call for participation: Help is requested to fix this issue.
Milestone
0.5

Comments

@tobz
Copy link
Collaborator

tobz commented Aug 16, 2020

Bug Report

Version

0.3.0

Platform

Linux consigliere 5.4.0-40-generic #44-Ubuntu SMP Tue Jun 23 00:01:04 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Description

As tonic::Interceptor is not unwind safe, it is not suitable for use within objects/codepath that themselves must be unwind safe, such as gotham. This is particularly thorny with crates like gotham where storing objects in middleware -- for access during request handling -- is the norm for holding shared state.

/cc @LucioFranco
@tobz
Copy link
Collaborator Author

tobz commented Aug 16, 2020

This playground is an MVCE of the issue, where SharedFn can be thought of as Interceptor: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=769c3f025aa3b7cf07a9556152819c53

@LucioFranco LucioFranco added C-bug Category: Something isn't working A-tonic E-help-wanted Call for participation: Help is requested to fix this issue. labels Aug 17, 2020
@LucioFranco LucioFranco added this to the 0.4 milestone Nov 27, 2020
@LucioFranco
Copy link
Member

This doesn't seem to hard? We can for sure include this in 0.5

davidpdrsn added a commit that referenced this issue May 12, 2021
@davidpdrsn
fix(tonic): make Interceptor UnwindSafe
8ad2cfe 
Fixes #429
@davidpdrsn davidpdrsn mentioned this issue May 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tonic C-bug Category: Something isn't working E-help-wanted Call for participation: Help is requested to fix this issue.
Projects
None yet
Milestone
0.5
Development

Successfully merging a pull request may close this issue.

fix(tonic): make Interceptor UnwindSafe hyperium/tonic
2 participants
@tobz @LucioFranco