Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transport): Expose tcp keepalive to clients & servers #151

Merged
merged 4 commits into from
Dec 6, 2019

Conversation

zenria
Copy link
Contributor

@zenria zenria commented Nov 22, 2019

Motivation

Long running tcp connections (grpc streaming), with very low activity may be silently disconnected if done though firewalls or NAT routers. TCP keepalive fixes this.

Solution

Expose hyper tcp_keepalive api on Endpoint and Server.

@jen20
Copy link
Contributor

jen20 commented Nov 25, 2019

Hi @zenria! Thanks for opening up a pull request, we much appreciate the contribution! It looks like your PR is fine, but we need to upgrade some other dependencies to get the build green before merging it. I'll try to look at that sometime either today or tomorrow.

Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LucioFranco
Copy link
Member

Once we get deny working which I think you just need to merge master we can merge this! Thanks!

* master:
  Upgrade to `tokio 0.2` (hyperium#163)
  chore(interop): Update console dep (hyperium#155)
  Temporarily allow duplicate crossbeam-queue crates (hyperium#153)

# Conflicts:
#	tonic/src/transport/server.rs
@zenria
Copy link
Contributor Author

zenria commented Dec 6, 2019

I've updated my PR so it can merge with current master

Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thank you!

@LucioFranco LucioFranco changed the title Expose tcp keepalive to clients & servers feat(transport): Expose tcp keepalive to clients & servers Dec 6, 2019
@LucioFranco LucioFranco merged commit caccfad into hyperium:master Dec 6, 2019
rabbitinspace pushed a commit to satelit-project/tonic that referenced this pull request Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants