feat(transport): Unify API for setting service to be via Routes instance #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Reduces transport layer's responsibility and makes easier to maintain it.
Solution
Warning
This proposal contains breaking changes.
Unifies API for setting services to be via
Routesinstance. This pull request removesadd_service,add_optional_serviceAPI fromServerandRouter, and refactorRoutesandRoutesBuilderallowed by this change. As these APIs seem to increase the complexity rather than the benefit it provides, they could be removed for the purpose of improving the maintainability.