feat: Use http::Extensions directly #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes sense to me but I'd like to review/merge it after #1670 is merged. |
17 tasks
tottoto
force-pushed
the
use-http-extensions-directly
branch
2 times, most recently
from
dca425e
to
2770fe9
Compare
tottoto
force-pushed
the
use-http-extensions-directly
branch
from
2770fe9
to
9bf800a
Compare
djc
approved these changes
Jun 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Makes
tonic's implementations thinner.As
tonic's ownExtensionstype do not anything than the wrapper type ofhttp::Extensions, there seems to be no advantage other than not being effected from changes byhttp::Extensions. This benefit might be small because thehttpcrate's stability term is longer thantonic's one.Solution
Uses
http::Extensionsdirectly.