tonic-reflection: Restructure module to prep reintroducing v1alpha #1802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To simplify API verification, this is a prepatory change to shift around the v1 support to allow for a cleaner v1alpha reintroduction. * Created a multi-file version of the server.rs module * Added mod.rs containing the base error with associated imports * Added v1.rs containing the v1 version of the reflection server
mkatychev
added a commit
to knox-networks/tonic
that referenced
this pull request
Aug 19, 2024
…lpha (hyperium#1802)" This reverts commit aa57ffe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To simplify API verification, this is a prepatory change to shift around the v1 support to allow for a cleaner v1alpha reintroduction.
Errorwith associated imports / exportsMotivation
The current
v1reflection API support is lacking in various existing tools (like Postman and Kreya).From feedback in #1787, we should split the change into multiple PRs.
Solution
This change splits the server module to enable us to re-add the
v1alphasupport in a later PR a cleaner fashion.