-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: prepare 0.12.3 release #1899
Conversation
a446bfb
to
3dcb73b
Compare
Could we please get #1938 into this release as well? |
More, importantly, we should consider: (Which tweaks newly public API.) |
@djc actually, in the current latest tonic release, if the TLS server is configured, and the server is exposed publicly (which is the case for some setup I guess), a external non authenticated user can very easily bring down the tonic server without any issues (HTTP requests or TCP packets to the TLS server). IMHO 0.12.3 should be released quickly with the fix (and maybe adding the impacted versions on rustsec? Or at least a warning somewhere) |
+1, it's a pretty serious regression from 0.12.1 |
The risk/severity was adequately explained in #1938 -- I agree that we should merge and release this but unfortunately I don't have the privileges to release and there's some governance discussions between the maintainers. So no need for +1 comments (which are actually universally unhelpful). |
Gotcha, wasn't aware of the governance issues! |
I am going to try to get the other PRs we want for this release and get this out this week |
Looks forward for this release since the #1948 helps a lot! |
@LucioFranco thanks for getting this merged, what has to happen for the 0.12.3 release to be pushed to crates.io ? I see the build passed on master but I don't know the process from there. |
@zakhenry for my meeting to end so I could publish :) |
@zakhenry its been published, let me know if you run into any issues. |
No description provided.