-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(transport): Upgrade rustls and base64 #251
Conversation
Hi @repi! Thanks for the pull request here. Update: I spoke too soon! It does actually look like we're pulling in two different versions of base64 here via transitive dependencies. |
I was going to PR Update: latest |
@repi thanks! Yeah, once rustls gets a publish on crates io lets do both of them in here and then make deny happy. :) |
@LucioFranco new rustls 0.17 out now that uses this |
@repi perfect, I am going to coordinate this with a new 0.2 release of tonic since we expose rustls in our public API. Looks like we need to bump rustls' version to make deny happy too :) |
@repi friendly ping :) Seems like we can finally merge this and update rustls? |
@LucioFranco there, tested upgrading rustls crates as well now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.