Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(transport): Upgrade rustls and base64 #251

Merged
merged 3 commits into from
Mar 30, 2020

Conversation

repi
Copy link
Contributor

@repi repi commented Jan 25, 2020

No description provided.

@jen20
Copy link
Contributor

jen20 commented Jan 25, 2020

Hi @repi! Thanks for the pull request here. The CI failure you're seeing is not actually a result of your change, we'll need to either tweak the cargo-deny settings to avoid removing our dependency on spin or take one of the other actions. In the interests of getting your PR merged as soon as possible, I think the first option is the best for now, I'll look at this shortly.

Update: I spoke too soon! It does actually look like we're pulling in two different versions of base64 here via transitive dependencies.

@repi
Copy link
Contributor Author

repi commented Jan 25, 2020

I was going to PR rustls also about upgrading to base64 0.11, so we can wait with this one until rustls has upgraded so one doesn't bring in multiple versions of it.

Update: latest rustls master is on base64 0.11 already, but no new release has been published

@LucioFranco
Copy link
Member

@repi thanks! Yeah, once rustls gets a publish on crates io lets do both of them in here and then make deny happy. :)

@repi
Copy link
Contributor Author

repi commented Feb 29, 2020

@LucioFranco new rustls 0.17 out now that uses this

@LucioFranco
Copy link
Member

@repi perfect, I am going to coordinate this with a new 0.2 release of tonic since we expose rustls in our public API.

Looks like we need to bump rustls' version to make deny happy too :)

@LucioFranco
Copy link
Member

@repi friendly ping :) Seems like we can finally merge this and update rustls?

@repi repi changed the title Upgrade base64 0.10 -> 0.11 Upgrade rustls and base64 Mar 29, 2020
@repi
Copy link
Contributor Author

repi commented Mar 29, 2020

@LucioFranco there, tested upgrading rustls crates as well now!

Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LucioFranco LucioFranco changed the title Upgrade rustls and base64 chore(transport): Upgrade rustls and base64 Mar 30, 2020
@LucioFranco LucioFranco merged commit 25569e0 into hyperium:master Mar 30, 2020
@LucioFranco LucioFranco deleted the base64-0.11 branch March 30, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants