feat(tonic): Extract transport error source when creating Status #766
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When experiencing transport errors the status object doesn't give much useful information:
Status { code: Unknown, message: "transport error", source: None }
."transport error" is the display message for
tonic::transport::error::Error
of kindtonic::transport::error::Kind::Transport
.tonic::transport::error::Error
contains asource
field which could give more information about the underlying issue but is not included in the display message nor extracted into the status object.Solution
When creating a
Status
from anBox<dyn Error>
we tries to extract thesource
data if it is atonic::transport::error::Error
.