Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(codec): Properly decode partial DATA frames #83

Merged
merged 28 commits into from
Oct 22, 2019
Merged

fix(codec): Properly decode partial DATA frames #83

merged 28 commits into from
Oct 22, 2019

Commits on Oct 21, 2019

  1. Add blobservice example for smoke testing

    Phillip Cloud committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    c8a4c7c View commit details
    Browse the repository at this point in the history

  2. Remove publicity from example

    Phillip Cloud committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    00c415e View commit details
    Browse the repository at this point in the history

  3. Make empty struct more concise

    Phillip Cloud committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    bb8acae View commit details
    Browse the repository at this point in the history

  4. Expose HEADER_SIZE and BUFFER_SIZE as crate public to avoid duping co… 

    …nstants
    Phillip Cloud committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    88abfdf View commit details
    Browse the repository at this point in the history

  5. Make sure our encoded buffer has the correct lower bound in size

    Phillip Cloud committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    893f990 View commit details
    Browse the repository at this point in the history

  6. Use crate-public constants in encode.rs

    Phillip Cloud committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    fec5d09 View commit details
    Browse the repository at this point in the history

  7. Use crate-public constants in decode.rs

    Phillip Cloud committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    ce2ae98 View commit details
    Browse the repository at this point in the history

  8. Rename fields for clarity in later usage

    Phillip Cloud committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    a60b3ed View commit details
    Browse the repository at this point in the history

  9. Ensure that if we do not have enough bytes for header + message that … 

    …we continue reading
    Phillip Cloud committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    c92bd82 View commit details
    Browse the repository at this point in the history

  10. Add comments describing the flow of data

    Phillip Cloud committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    0733aec View commit details
    Browse the repository at this point in the history

  11. No need for match

    Phillip Cloud committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    13277a1 View commit details
    Browse the repository at this point in the history

  12. Rename variables for clarity

    Phillip Cloud committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    a491622 View commit details
    Browse the repository at this point in the history

  13. Relax the assertion in encoding, since it is not actually required

    Phillip Cloud committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    36164a5 View commit details
    Browse the repository at this point in the history

  14. Move blobservice back to multiple threads

    Phillip Cloud committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    2ddd3af View commit details
    Browse the repository at this point in the history

  15. Remove logging dependencies

    Phillip Cloud committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    306bae4 View commit details
    Browse the repository at this point in the history

  16. Give an example of how the bug can happen in a comment

    Phillip Cloud committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    fc8500d View commit details
    Browse the repository at this point in the history

  17. Use message_len for maximum rustiness

    Phillip Cloud committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    6aecefd View commit details
    Browse the repository at this point in the history

  18. Use message instead of try_next

    Phillip Cloud committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    7fd4d7d View commit details
    Browse the repository at this point in the history

  19. Remove license

    Phillip Cloud committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    0090592 View commit details
    Browse the repository at this point in the history

  20. Remove blobservice

    Phillip Cloud committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    0b46a6f View commit details
    Browse the repository at this point in the history

  21. Revert changes to decode.rs

    Phillip Cloud committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    e79db30 View commit details
    Browse the repository at this point in the history

  22. Simplify the check

    Phillip Cloud committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    f0fb03e View commit details
    Browse the repository at this point in the history

  23. Revert body change

    Phillip Cloud committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    36c6871 View commit details
    Browse the repository at this point in the history

  24. Revert refactor

    Phillip Cloud committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    3abd90b View commit details
    Browse the repository at this point in the history

  25. Fix decode test to actually run

    Phillip Cloud committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    c7381a3 View commit details
    Browse the repository at this point in the history

  26. Checkpoint

    Phillip Cloud committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    2d9c5b8 View commit details
    Browse the repository at this point in the history

  27. Modify existing test to send partial bodies

    Phillip Cloud committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    bdcac37 View commit details
    Browse the repository at this point in the history

  28. Shorten syntax

    Phillip Cloud committed Oct 21, 2019
    Configuration menu
    Copy the full SHA
    b5e5ea7 View commit details
    Browse the repository at this point in the history