Allow access to peer identity in a gRPC Server Interceptor #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucioFranco
reviewed
Oct 23, 2019
| .identity(server_identity) | ||
| .client_ca_root(client_ca_cert) | ||
| .clone(); | ||
|
|
||
| Server::builder() | ||
| .tls_config(&tls) | ||
| .interceptor_fn(|svc, req| { |
There was a problem hiding this comment.
I really wonder if it makes sense to change this to wrap request
intercetptor_req_fn(|req| {
// do something to req
Some(req)
// or to cancel the request
None
})
LucioFranco
reviewed
Oct 23, 2019
tonic/Cargo.toml
Outdated
| @@ -75,6 +75,9 @@ openssl1 = { package = "openssl", version = "0.10", optional = true } | |||
| # rustls | |||
| tokio-rustls = { version = "=0.12.0-alpha.4", optional = true } | |||
|
|
|||
| # tls (general) | |||
| x509-parser = "0.6" | |||
There was a problem hiding this comment.
probably want to make this optional?
LucioFranco
reviewed
Oct 23, 2019
tonic/src/transport/server.rs
Outdated
| @@ -351,7 +352,7 @@ impl Stream for TcpIncoming { | |||
| } | |||
|
|
|||
| #[derive(Debug)] | |||
| struct Svc<S>(S); | |||
| struct Svc<S>(S, Option<String>); | |||
There was a problem hiding this comment.
lets make this a real struct with like names for things 😄
LucioFranco
reviewed
Oct 23, 2019
| } | ||
|
|
||
| /// IO structure used by GRPC clients | ||
| pub(crate) struct ClientIo(Pin<Box<dyn Io>>); |
There was a problem hiding this comment.
why not use a general IO type so we don't have to add this?
LucioFranco
reviewed
Oct 23, 2019
jen20
force-pushed
the
jen20/tls-identity-in-request
branch
from
744ed40 to
24de805
Compare
|
Closing this in favor of #228 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial work in progress of a mechanism to access the TLS identity of the client in a server interceptor.