Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds discord notification #125

Merged
merged 4 commits into from
Apr 6, 2021

Conversation

galanggg
Copy link
Contributor

@galanggg galanggg commented Apr 4, 2021

Hello everyone, I made this pr so that Monika can send notifications via Discord. Please kindly check and review it thanks.

@galanggg galanggg mentioned this pull request Apr 4, 2021
@kevin-hyperjump
Copy link
Contributor

Hello @galanggg, thank your for the PR we're really appreciate your hard work on this section 🍻

Have you update the documentation and add discord in the notification section?

@galanggg
Copy link
Contributor Author

galanggg commented Apr 5, 2021

Hello @galanggg, thank your for the PR we're really appreciate your hard work on this section

Have you update the documentation and add discord in the notification section?

Hello @kevinhermawan, thank you so much I really appreciate it. 🙏

Sure I will update the documentation for discord notification.

@galanggg
Copy link
Contributor Author

galanggg commented Apr 5, 2021

Hi @kevinhermawan @dennypradipta, I just added the documentation for discord and changed the name from discordWebhook to discord also add some tests for discord notification.

Copy link
Contributor

@kevin-hyperjump kevin-hyperjump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@dennypradipta dennypradipta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Copy link
Contributor

@dennypradipta dennypradipta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@dennypradipta dennypradipta merged commit bec5143 into hyperjumptech:main Apr 6, 2021
@galanggg
Copy link
Contributor Author

galanggg commented Apr 6, 2021

Thanks all 🚀

kevin-hyperjump pushed a commit to kevin-hyperjump/monika that referenced this pull request Aug 13, 2021
* feat: adds discord notification

* feat(discord): fix naming and update the docs.

Co-authored-by: Denny Pradipta <denny@hyperjump.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants