[Feat] Removing Axios for Native Fetch #1278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syamsudotdev
reviewed
May 2, 2024
| url: downloadUri, | ||
| responseType: 'stream', | ||
| }) | ||
|
|
||
| const { data: checksum }: { data: string } = await sendHttpRequest({ | ||
| const { data: downloadStream } = (await resp.json()) as { data: Stream } |
There was a problem hiding this comment.
I think we can get stream from resp.body instead of resp.json() ?
ref https://developer.mozilla.org/en-US/docs/Web/API/Streams_API/Using_readable_streams
sapiderman
requested review from
nicnocquee,
raosan,
ilmiawan,
syamsudotdev,
dennypradipta,
kevin-hyperjump,
lukman7788 and
herenacreative
| } | ||
|
|
||
| private async report(): Promise<void> { | ||
| // Create a task data object | ||
| const taskData = { | ||
| apiKey: this.apiKey, | ||
| httpClient: this.httpClient, | ||
| // httpClient: this.httpClient, |
ilmiawan
reviewed
Jun 24, 2024
| } | ||
|
|
||
| function mapInsomniaToConfig(data: unknown): Config { | ||
| function mapInsomniaToConfig( |
There was a problem hiding this comment.
for effectivity mapInsomniaToConfig and mapInsomniaRequestToConfig can be merged. By making mapInsomniaToConfig as a pure function that return insomniaRequests array, then call it from inside mapInsomniaRequestToConfig rather than just passing parameters to the next function.
|
@sapiderman theres snapcraft-credential file committed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monika Pull Request (PR)
What feature/issue does this PR add
How did you implement / how did you fix it
How to test
npm start -- -c test.yamlshould worknpm testshould all passmonika -c https://raw.githubusercontent.com/hyperjumptech/monika/main/config_sample/config.desktop.example.ymlshould be fetched properlymonika --auto-update patchshould work