feat(notification): facebook workplace integration #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicnocquee
requested changes
Jun 11, 2021
| | ---- | ----------------------------------------------- | ------------------ | | ||
| | ID | Notification identity number | `Workplace12345` | | ||
| | Type | Notification types | `slack` | | ||
| | ID | It's located at thread url, in the last segment | `6367478493277649` | |
There was a problem hiding this comment.
I think the key here should be thread_id, right? Can you also please add an example of the thread URL?
There was a problem hiding this comment.
ah ya, it should be thread_id, I will update it. and here is the thread URL example
|
Hello @adeyahya thank you for contributing! May I ask you to provide screenshots of the notifications sent to Facebook Workplace? 😀 Thank you |
kevin-hyperjump
approved these changes
Jun 11, 2021
here is the screenshot |
adeyahya
force-pushed
the
main
branch
2 times, most recently
from
bc5cc98
to
78121c5
Compare
ilmiawan
reviewed
Jun 11, 2021
nicnocquee
approved these changes
Jun 11, 2021
Merged
kevin-hyperjump
pushed a commit
to kevin-hyperjump/monika
that referenced
this pull request
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone, I made this pr so that Monika can send notifications via Facebook Workplace. Please kindly check and review it thanks.